Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building for non-abi3 pypy wheels when the abi3 feature is enabled #460

Closed
Tracked by #115
konstin opened this issue Mar 4, 2021 · 3 comments · Fixed by #678
Closed
Tracked by #115

Allow building for non-abi3 pypy wheels when the abi3 feature is enabled #460

konstin opened this issue Mar 4, 2021 · 3 comments · Fixed by #678

Comments

@konstin
Copy link
Member

konstin commented Mar 4, 2021

Currently, activating the abi3 feature means that you can't build wheels for pypy, as abi3 wheel are incompatible with pypy and the abi3 causes -i to be ignored. There should be a solution that both builds for abi3 by defaults and allows building for pypy if requested.

@konstin konstin changed the title pypy and abi3 Allow buliding for pypy with abi3 Mar 4, 2021
@konstin konstin mentioned this issue Mar 4, 2021
11 tasks
@konstin konstin changed the title Allow buliding for pypy with abi3 Allow building for pypy with abi3 Mar 4, 2021
@kngwyu
Copy link
Member

kngwyu commented Mar 5, 2021

But doesn't it require upstream support? https://foss.heptapod.net/pypy/pypy/-/issues/3397

@davidhewitt
Copy link
Member

FYI for PyO3 0.14 we're going to make abi3 + PyPy a hard error: PyO3/pyo3#1469

@konstin
Copy link
Member Author

konstin commented Mar 5, 2021

Sorry, I misphrased that: It should be possible to build a non-abi3 pypy wheels even when the abi3 feature is enabled.

Once pypy also has a stable abi, there should be switch to build for both, but that's something to figure out once we know the details about pypy's abi3

@konstin konstin changed the title Allow building for pypy with abi3 Allow building for non-abi3 pypy wheels when the abi3 feature is enabled Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants