-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show warning when abi3 is used with PyPy #1469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should definitely include this in the ## Packaging
feature at the top of the changelog, because it could break user's builds:
### Packaging
- The `abi3` feature is now a compile error when building for `PyPy`. [#1469](https://github.com/PyO3/pyo3/pull/1469)
On setuptools-rust
they'll have to write like this example: https://github.com/PyO3/setuptools-rust/blob/14703b86325e2c53cebec22937e9ca48c7cdeb70/examples/rust_with_cffi/setup.py#L24-L25
src/lib.rs
Outdated
compile_error!(concat!( | ||
"PyPy still does not support abi3. ", | ||
"See https://foss.heptapod.net/pypy/pypy/-/issues/3397 for the discussion." | ||
)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of wording changes which I think makes it read easier:
compile_error!(concat!( | |
"PyPy still does not support abi3. ", | |
"See https://foss.heptapod.net/pypy/pypy/-/issues/3397 for the discussion." | |
)); | |
compile_error!( | |
"PyPy does not yet support abi3. \ | |
See https://foss.heptapod.net/pypy/pypy/-/issues/3397 for more information." | |
); |
I think it would be good if there was a way to build for pypy when the abi3 feature is enabled; I'd say the abi3 feature should require that only abi3 apis are used, while it should be possible to build non-abi3 wheels. Otherwise someone who wants to ship wheels for both cpython abi3 and pypy would need to add an optional feature for enabling abi3 and make sure cpython wheels are build with the feature and the pypy wheels without it. |
|
c33399d
to
8669895
Compare
8669895
to
352c20d
Compare
6f889b3
to
a01169f
Compare
a01169f
to
4ec78e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just a couple of final suggestions.
The build script refactoring is very nice 👍
Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
👍 thanks! |
Thanks, the warning is a good solution 👍 |
Thanks @davidhewitt for contacting to PyPy maintainers.