Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maturin develop in Windows conda virtual environment #1146

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

messense
Copy link
Member

@messense messense commented Sep 27, 2022

TODO

  • Add develop conda venv test
  • Only run conda tests when conda is present in PATH

Fixes #1145

@netlify
Copy link

netlify bot commented Sep 27, 2022

Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit 3e27511
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/6334f40405414d00080af7e1
😎 Deploy Preview https://deploy-preview-1146--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@messense messense force-pushed the fix-windows-conda branch 3 times, most recently from 5e5e374 to f45fabf Compare September 27, 2022 14:43
@messense messense force-pushed the fix-windows-conda branch 3 times, most recently from ce286b7 to bf695e1 Compare September 28, 2022 03:46
@messense messense force-pushed the fix-windows-conda branch 3 times, most recently from 703a56d to 3e27511 Compare September 29, 2022 01:25
@messense
Copy link
Member Author

Will address the TODOs in another PR.

@messense messense merged commit 0d0d8c4 into PyO3:main Sep 29, 2022
@messense messense deleted the fix-windows-conda branch September 29, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scripts/python.exe not found in conda environment
1 participant