Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error when required features of bin target isn't enabled #1299

Merged
merged 1 commit into from
Nov 26, 2022

Conversation

messense
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Nov 26, 2022

Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit 6e496a9
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/638178f37de9b60008434420
😎 Deploy Preview https://deploy-preview-1299--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@messense messense force-pushed the bin-required-features branch from 85ab051 to 6e496a9 Compare November 26, 2022 02:24
@messense
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Nov 26, 2022
1299: Fix build error when required features of bin target isn't enabled r=messense a=messense



Co-authored-by: messense <messense@icloud.com>
@messense messense added the bindings/bin bin bindings label Nov 26, 2022
@bors
Copy link
Contributor

bors bot commented Nov 26, 2022

Build failed:

@messense messense merged commit 44c9abe into PyO3:main Nov 26, 2022
@messense messense deleted the bin-required-features branch November 26, 2022 02:45
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Dec 2, 2022
https://build.opensuse.org/request/show/1039390
by user mia + dimstar_suse
- Update to v0.14.3:
  * Bump MSRV to 1.62.0
    gh#PyO3/maturin#1297
  * CI: Run ruff in lint jobs
    gh#PyO3/maturin#1298
  * Fix build error when required features of bin target isn't
    enabled
    gh#PyO3/maturin#1299
  * Build and publish armv6l wheels for maturin
    gh#PyO3/maturin#1300
  * Fix wrong platform tag when building in i386 docker container
    on x86_64 host
    gh#PyO3/maturin#1301
  * Fix wrong platform tag when building in armv7 docker container
    on aarch64 host
    gh#PyO3/maturin#1303
  * CI: Stop caching test crates target directory
    gh#PyO3/maturin#1302
  * refactor: Use clap_complete_command
    gh#PyO3/maturin#1304
  * Remove human-panic dependency
    gh#PyO3/maturin#1305
  * chore: cargo update to remove rustix 0.35.x
    gh#PyO3/maturin#1307
  * chore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bindings/bin bin bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant