Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for packaging multiple pure Python packages #1378

Merged
merged 1 commit into from
Dec 29, 2022
Merged

Add support for packaging multiple pure Python packages #1378

merged 1 commit into from
Dec 29, 2022

Conversation

messense
Copy link
Member

Implements #1372 (comment)

@netlify
Copy link

netlify bot commented Dec 28, 2022 •
edited
Loading

✅ Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit ef2b09a
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/63acf224f77f49000878a39b
😎 Deploy Preview https://deploy-preview-1378--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@messense messense mentioned this pull request Dec 28, 2022
Closed
@messense messense added the configuration Configuration label Dec 28, 2022
@alecandido
Copy link

The PR looks sensible to me, but I'm not the best person to review, since I'm not experienced in maturin internals.

What I can do is testing in the demo project, building from source.

@messense messense marked this pull request as ready for review December 29, 2022 02:19
@messense
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 29, 2022

Build succeeded:

@bors bors bot merged commit c627d88 into PyO3:main Dec 29, 2022
@messense
Copy link
Member Author

Please try v0.14.8b1: https://pypi.org/project/maturin/0.14.8b1/

@messense messense deleted the python-packages branch December 29, 2022 05:48
@messense messense mentioned this pull request Dec 30, 2022
Merged
bors bot added a commit that referenced this pull request Dec 30, 2022
@bors @messense
Merge #1380
037442b 
1380: Detect src-layout for pure Rust projects with multiple Python packages r=messense a=messense

Follow-up of #1378, `python-packages` actually slightly changes the meaning of mixed Rust/Python project layout.

Co-authored-by: messense <messense@icloud.com>
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Jan 9, 2023
@bmwiedemann
Update python-maturin to version 0.14.8 / rev 23 via SR 1056955
e5cb444 
https://build.opensuse.org/request/show/1056955
by user mia + dimstar_suse
- Update to v0.14.8:
  * Add support for packaging multiple pure Python packages
    gh#PyO3/maturin#1378
  * Fallback to sysconfig interpreters for pyo3 bindings
    gh#PyO3/maturin#1381
@messense messense mentioned this pull request May 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
configuration Configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@messense @alecandido