Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass MACOSX_DEPLOYMENT_TARGET when query default value from rustc #1395

Merged
merged 1 commit into from
Jan 8, 2023

Conversation

messense
Copy link
Member

@messense messense commented Jan 8, 2023

Otherwise rustc will output the same target version as MACOSX_DEPLOYMENT_TARGET.

@netlify
Copy link

netlify bot commented Jan 8, 2023

Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit 80b945b
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/63ba4fb255bef7000850f327
😎 Deploy Preview https://deploy-preview-1395--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@messense messense force-pushed the fix-rustc_macosx_target_version branch from 661fc3c to 80b945b Compare January 8, 2023 05:08
@messense messense merged commit 6fa1751 into PyO3:main Jan 8, 2023
@messense messense deleted the fix-rustc_macosx_target_version branch January 8, 2023 05:28
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Jan 12, 2023
https://build.opensuse.org/request/show/1057818
by user mia + dimstar_suse
- Don't pass MACOSX_DEPLOYMENT_TARGET when query default value from
  rustc
  gh#PyO3/maturin#1395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant