Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Try using sccache to replace rust-cache #1425

Merged
merged 6 commits into from
Jan 28, 2023
Merged

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Jan 24, 2023

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@netlify
Copy link

netlify bot commented Jan 24, 2023

Deploy Preview for maturin-guide ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 23a9d4d
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/63d48e8fd38a45000825268b
😎 Deploy Preview https://deploy-preview-1425--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@messense
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jan 24, 2023
@Xuanwo
Copy link
Contributor Author

Xuanwo commented Jan 24, 2023

91103e1 is running on a different branch, so only the cache in its branch is used. For evaluating sccache's overall performance, please try again.

After this PR gets merged, all other branches can reuse the cache from the main branch.

Read more about the cache loading logic here: https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#restrictions-for-accessing-a-cache

@bors
Copy link
Contributor

bors bot commented Jan 24, 2023

try

Build failed:

@Xuanwo
Copy link
Contributor Author

Xuanwo commented Jan 24, 2023

bors try

@bors
Copy link
Contributor

bors bot commented Jan 24, 2023

🔒 Permission denied

Existing reviewers: click here to make Xuanwo a reviewer

@messense
Copy link
Member

bors retry

bors bot added a commit that referenced this pull request Jan 24, 2023
@bors
Copy link
Contributor

bors bot commented Jan 24, 2023

try

Build failed:

@Xuanwo
Copy link
Contributor Author

Xuanwo commented Jan 24, 2023

image

Sccache will be slower than rust-cache when Cargo.lock nearly not changed.

@messense
Copy link
Member

Overall it looks a lot better than the last time I tried.

Looks like the gha cache API limit issue also affects the Test Docker job, I guess we can switch to registry cache instead in docker-build-push-action to avoid it.

Signed-off-by: Xuanwo <github@xuanwo.io>
@messense
Copy link
Member

bors retry

bors bot added a commit that referenced this pull request Jan 25, 2023
@bors
Copy link
Contributor

bors bot commented Jan 25, 2023

try

Build failed:

@Xuanwo
Copy link
Contributor Author

Xuanwo commented Jan 25, 2023

Test Docker failed for:

ERROR: failed to solve: error writing layer blob: server message: insufficient_scope: authorization failed
Error: buildx failed with: ERROR: failed to solve: error writing layer blob: server message: insufficient_scope: authorization failed

@Xuanwo
Copy link
Contributor Author

Xuanwo commented Jan 25, 2023

BTW, 3rd seems much faster:

image

Co-authored-by: messense <messense@icloud.com>
@messense
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jan 28, 2023
Signed-off-by: Xuanwo <github@xuanwo.io>
@messense
Copy link
Member

Oops.

bors retry

@bors
Copy link
Contributor

bors bot commented Jan 28, 2023

try

Already running a review

@bors
Copy link
Contributor

bors bot commented Jan 28, 2023

try

Build failed:

@messense
Copy link
Member

bors retry

bors bot added a commit that referenced this pull request Jan 28, 2023
@bors
Copy link
Contributor

bors bot commented Jan 28, 2023

try

Build failed:

Signed-off-by: Xuanwo <github@xuanwo.io>
@messense
Copy link
Member

bors retry

bors bot added a commit that referenced this pull request Jan 28, 2023
@Xuanwo Xuanwo marked this pull request as ready for review January 28, 2023 03:16
@bors
Copy link
Contributor

bors bot commented Jan 28, 2023

try

Build succeeded:

@messense
Copy link
Member

✨ Merging, will switch to official version of the sccache-action when it's released. Thanks!

To populate the cache for staging branch:

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 28, 2023

@bors bors bot merged commit 7df6a66 into PyO3:main Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: Use sccache to replace rust-cache
2 participants