Fix emscripten action #1657
Merged
Fix emscripten action #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello and thanks for your software!
What did not work
In the output of
generate-ciwith theemscriptenoption, the version of python inmaturin_argswas fixed at "3.10". But the stable version of pyodide-build is only compatible with "3.11" right now.What I did
Now the ci fetches the current python version for pyodide with
pyodide config get python_versionsimilarly to what was already done for the emscripten_version. Like so, it should adapt to any future new versionsDoubts
I'm new to Rust, so feel free to change anything. Tests are passing and the ci runs there in my library: https://github.com/cds-astro/mocpy/actions/workflows/emscripten.yml but I never know what I could have broken.