Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed python 3.7 compatibility #1764

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

mbway
Copy link
Contributor

@mbway mbway commented Sep 3, 2023

in the pyproject.toml file, maturin indicates that the minimum supported python version is 3.7 but the code uses

  • subscripted builtins (i.e. list[str] instead of typing.List[str]) which was introduced in python 3.9
  • | to denote unions (i.e. str | int instead of typing.Union[str, int]) which was introduced in python 3.10

(the import hook in #1748 also aims to be compatible with python 3.7)

@netlify
Copy link

netlify bot commented Sep 3, 2023

Deploy Preview for maturin-guide ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f8659ee
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/64f4f27b7a4911000802add8
😎 Deploy Preview https://deploy-preview-1764--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@messense messense merged commit f6e5679 into PyO3:main Sep 4, 2023
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants