Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect target based on interpreter for pep517 build-wheel #2086

Closed
wants to merge 2 commits into from

Conversation

kcking
Copy link
Contributor

@kcking kcking commented May 14, 2024

This PR detects the desired target based on the python interpreter for pep517 commands, similar to the detection already in place for maturin develop.

This fixes maturin pep517 build-wheel building for the host architecture, even when the current python interpreter is a different architecture, ie. when using an x86_64 python on arm64 macos host.

Related issue: #2041

Copy link

netlify bot commented May 14, 2024

Deploy Preview for maturin-guide ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 76a7ea2
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/6643f3a6c0321700087b6186
😎 Deploy Preview https://deploy-preview-2086--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kcking kcking force-pushed the main branch 3 times, most recently from 59b8474 to 48c9ef2 Compare May 14, 2024 19:46
Revert "Detect target based on interpreter for pep517 build-wheel"

This reverts commit 88bce88.
@kcking kcking closed this May 14, 2024
@messense
Copy link
Member

Thanks for the PR, consider reopen it regardless of the CI issue, it's a known issue/bug of virualenv on Windows that occurs from time to time.

@kcking
Copy link
Contributor Author

kcking commented May 15, 2024

Ah gotcha, thanks! Re-created as #2088 since I wasn't able to reopen this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants