-
-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: copy .pdb
files to Editable Installation
and Wheel
for easier debugging on windows
#2220
Open
WSH032
wants to merge
7
commits into
PyO3:main
Choose a base branch
from
WSH032:debuginfo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e3fd1f1
feat: copy `.pdb` files to `Editable Installation` and `Wheel` for ea…
WSH032 e579083
fix: the PDB file of `foo-bar.exe` is `foo_bar.pdb`
WSH032 286e4a6
test: enable `--with-debuginfo` for testing on `msvc`
WSH032 64f8824
test: fix different output of trycmd cli testing
WSH032 1a85cb5
fix: use `Target::is_msvc` instead of `cfg!(target_env="msvc")` to av…
WSH032 b9a034f
test: add `test_develop` and `check_wheel_files` testing for `--with-…
WSH032 fe46b4c
feat: add `*.pdb` to `.gitignore.j2` template
WSH032 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ venv*/ | |
*.o | ||
*.so | ||
*.py[cdo] | ||
*.pdb | ||
__pycache__/ | ||
*.egg-info/ | ||
*.egg | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can't be used together with
--strip
. (Not sure ifclap
supports this kind of setup though)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On
MSVC
, even ifRUSTFLAGS="-Cstrip=symbols"
is specified,rustc
(at least with version1.81
that I used) will still generate a.pdb
file, so we can't let it conflict. Not sure how it behaves onmacOS
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But does the
.pdb
file contain useful information?