Update goblin to 0.9 #2284
Merged
Update goblin to 0.9 #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The breaking change from 0.8.0 appears to be the addition of a value to a pub enum associated with TE (terse executable) support; this does not look like it should affect maturin’s usage of goblin since it doesn’t match exhaustively on this enum. https://github.com/m4b/goblin/blob/d096260201158ed34d64728fd1ab0ca125e2f956/CHANGELOG.md#092----2024-10-26
musicinmybrain
force-pushed
the
goblin-0.9
branch
from
d86468d
to
b7c1fa8
Compare
|
Could you please also update related deps now that I've release new versions? Thanks! |
- Now Cargo.lock contains only goblin 0.9; nothing requires goblin 0.8
Yes, I missed that you had already released! Pushing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The breaking change from 0.8.0 appears to be the addition of a value to a pub enum associated with TE (terse executable) support; this does not look like it should affect maturin’s usage of goblin since it doesn’t match exhaustively on this enum.
https://github.com/m4b/goblin/blob/d096260201158ed34d64728fd1ab0ca125e2f956/CHANGELOG.md#092----2024-10-26
I’ve also filed PR’s for both of the crates that are still asking for goblin 0.8.0 in
maturin’s dependency tree: