Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check the install backend version to give more informative error messages #2389

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

mbway
Copy link
Contributor

@mbway mbway commented Dec 17, 2024

since version 0.4.25, uv pip show --files is supported and can be used to set the package installed by maturin develop as editable without having to fallback to using pip. However several users are using old versions of uv and it would be better if the error message was clearer if an outdated uv is used.

This has caused confusion in these issues:

before:

✏️  Setting installed package as editable
💥 maturin failed
  Caused by: failed to list package files

after:

✏️  Setting installed package as editable
⚠️ Warning: failed to set package as editable: uv >= 0.4.25 is required for `show --files`. Version 0.4.23 was found.
🛠 Installed $PACKAGE

(note that installation now proceeds if setting as editable fails)

@mbway mbway force-pushed the uv_version_check branch 2 times, most recently from 209aff2 to c9387bf Compare December 17, 2024 22:04
@messense messense merged commit 7e784ed into PyO3:main Dec 18, 2024
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants