Replace lipo command line with fat-macho crate #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messense
force-pushed
the
fat-macho
branch
10 times, most recently
from
de41b12
to
bb640c6
Compare
messense
commented
Jan 27, 2021
| bindir="$(xcode-select --print-path)/Toolchains/XcodeDefault.xctoolchain/usr/bin" | ||
| echo "CC=${bindir}/clang" >> "${GITHUB_ENV}" | ||
| echo "CXX=${bindir}/clang++" >> "${GITHUB_ENV}" | ||
| echo "SDKROOT=$(xcrun --sdk macosx --show-sdk-path)" >> "${GITHUB_ENV}" |
There was a problem hiding this comment.
Xcode 12.2 and later can compile to both x86_64 and arm64 targets on Intel & Apple Silicon platforms. I am not sure why xcode-select alone does not work, had to setup CC, CXX etc.
messense
commented
Jan 27, 2021
konstin
reviewed
Feb 10, 2021
messense
force-pushed
the
fat-macho
branch
2 times, most recently
from
6365df1
to
a53fb1f
Compare
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lipois only available on macOS as a command line tool, the fat-macho crate implemented a cross platform Mach-O fat binary writer, makes it easier to do cross compilation.Based on #404