Build i686 musl wheel on GitHub Action #431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Afaik we can build this as a regular target on ubuntu-latest, so no need to go through cross, which I'd prefer |
|
I was originally try to use a regular target, but it now has too many |
|
Do you think https://github.com/PyO3/maturin/compare/github-actions-i686-unknown-linux-musl would work? |
|
I think that should work, thanks! |
|
Closing in favor of 64cf56d |
|
My version seems to fail: https://github.com/PyO3/maturin/runs/1963814800?check_suite_focus=true Do you by chance know why? |
|
Hmm, I am not sure. Looked at ring's build script, it uses clang instead of gcc for musl targets. Might be related: briansmith/ring#713 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of time spent on installing maturin to build wheel for 32-bit linux: https://github.com/messense/rjieba-py/runs/1933811414?check_suite_focus=true