Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show cargo rustc output when pip install maturin from sdist failed #514

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

messense
Copy link
Member

It's hard to debug #481 without rustc's output.

@konstin
Copy link
Member

konstin commented Apr 26, 2021

Good idea!

@konstin konstin merged commit 9f5afe0 into PyO3:main Apr 26, 2021
@messense messense deleted the setup-debug branch April 26, 2021 10:09
@messense
Copy link
Member Author

I just noticed that maturin isn't compiled with --release in setup.py, why not? @konstin

@konstin
Copy link
Member

konstin commented Apr 26, 2021

I totally missed that, feel free to add --release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants