Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace toml_edit with toml crate #577

Merged
merged 2 commits into from
Jul 1, 2021
Merged

Replace toml_edit with toml crate #577

merged 2 commits into from
Jul 1, 2021

Conversation

messense
Copy link
Member

Should hopefully fixes #541

@messense messense requested a review from konstin June 23, 2021 04:06
@messense
Copy link
Member Author

@bearcage Can you try this patch?

konstin
konstin approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit sad that we lose debugability, but yeah it's better to use the standard-compliant crate instead

@messense messense merged commit 920620d into PyO3:main Jul 1, 2021
@messense messense deleted the use-toml-crate branch July 1, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konstin konstin konstin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maturin's toml parser errors out on dotted keys in Cargo.toml when building sdists
2 participants
@messense @konstin