Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sdist with local path dependencies on Windows #580

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Fix sdist with local path dependencies on Windows #580

merged 2 commits into from
Jun 29, 2021

Conversation

messense
Copy link
Member

Closes #579

@messense messense force-pushed the fix-windows-sdist-local-deps branch from 660b832 to c8233ac Compare June 26, 2021 04:12
@messense messense changed the title Fix sdist with local dependencies on Windows Fix sdist with local path dependencies on Windows Jun 26, 2021
@andfoy
Copy link

andfoy commented Jun 28, 2021

@messense, does this also fix the issues related to maturin build?

@messense
Copy link
Member Author

does this also fix the issues related to maturin build?

Yes, the sdist generation code is shared.

@messense
Copy link
Member Author

I'm gonna merge this and publish a new beta release so users can try it.
@konstin Feel free to ask for changes, I can do follow-up PR to fix them.

@messense messense merged commit ac188f0 into PyO3:main Jun 29, 2021
@konstin
Copy link
Member

konstin commented Jun 30, 2021

Thanks, looks good! BTW @messense feel free to publish 0.11.0 final.

@messense messense deleted the fix-windows-sdist-local-deps branch November 27, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maturin sdists fails on Windows when using local dependencies
3 participants
@messense @andfoy @konstin