Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update keyring to 1.0.0 #721

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Update keyring to 1.0.0 #721

merged 1 commit into from
Dec 1, 2021

Conversation

messense
Copy link
Member

@messense messense commented Dec 1, 2021

@netlify
Copy link

netlify bot commented Dec 1, 2021 •
edited
Loading

✔️ Deploy Preview for maturin-guide canceled.

🔨 Explore the source changes: fb62994

🔍 Inspect the deploy log: https://app.netlify.com/sites/maturin-guide/deploys/61a783d93669df0007bc1cae

messense
messense commented Dec 1, 2021
View reviewed changes
.github/workflows/lint.yml
@@ -37,7 +37,7 @@ jobs:
- uses: actions-rs/cargo@v1
with:
command: clippy
args: -- -D warnings
args: --features password-storage -- -D warnings
Copy link
Member Author

@messense messense Dec 1, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

password-storage related code wasn't checked by clippy previously.

@messense messense merged commit f16fab7 into PyO3:main Dec 1, 2021
@messense messense deleted the keyring branch December 1, 2021 14:38
@konstin
Copy link
Member

konstin commented Dec 2, 2021

This allows making password-storage a default features (at least on linux) since this version doesn't depend on libdbus anymore so cargo build --target x86_64-unknown-linux-musl --features password-storage is still statically linked

@messense
Copy link
Member Author

messense commented Dec 2, 2021

This allows making password-storage a default features (at least on linux) since this version doesn't depend on libdbus anymore so cargo build --target x86_64-unknown-linux-musl --features password-storage is still statically linked

Yeah, I thought about it when doing the upgrade. I'll give it a try on CI later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@messense @konstin