Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PYO3_NO_PYTHON hack for Windows #848

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Remove PYO3_NO_PYTHON hack for Windows #848

merged 1 commit into from
Mar 15, 2022

Conversation

messense
Copy link
Member

@messense messense commented Mar 14, 2022 •
edited
Loading

Fixes #824

@netlify
Copy link

netlify bot commented Mar 14, 2022 •
edited
Loading

✔️ Deploy Preview for maturin-guide canceled.

🔨 Explore the source changes: 18d4214

🔍 Inspect the deploy log: https://app.netlify.com/sites/maturin-guide/deploys/622f47cd2e489d0009e69fa1

@messense messense mentioned this pull request Mar 14, 2022
Closed
2 tasks
@messense messense marked this pull request as ready for review March 14, 2022 13:46
@messense
Copy link
Member Author

CI is happy, but I want @konstin to double check this.

@messense messense requested a review from konstin March 14, 2022 13:47
@messense messense force-pushed the windows-no-no-python branch from 120ea33 to 18d4214 Compare March 14, 2022 13:48
konstin
konstin approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure on the details of that code anymore, last thing i remember was that on windows you always need to link the python dll so PYO3_NO_PYTHON but apparently that has changed since (https://github.com/PyO3/pyo3/blob/01788b722002d5c1494332fd04dbdbb23c268103/pyo3-build-config/src/lib.rs#L109-L115), so sorry but no idea

@messense messense merged commit e21c6cb into PyO3:main Mar 15, 2022
@messense messense deleted the windows-no-no-python branch March 15, 2022 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konstin konstin konstin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

maturin strips PYO3_CROSS_LIB_DIR from the build command env
2 participants
@messense @konstin