Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build sdist by default in maturin build command #955

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

messense
Copy link
Member

@messense messense commented Jun 7, 2022

This replaces --no-sdist with --sdist option to only build sdist
when --sdist is specified.

Part of #796

@netlify
Copy link

netlify bot commented Jun 7, 2022

Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit 657a209
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/62a1f47885c711000803a8d5
😎 Deploy Preview https://deploy-preview-955--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@messense messense mentioned this pull request Jun 7, 2022
6 tasks
@messense messense linked an issue Jun 7, 2022 that may be closed by this pull request
6 tasks
@messense
Copy link
Member Author

messense commented Jun 8, 2022

@konstin I wonder if we should keep --no-sdist in maturin publish command?

@konstin
Copy link
Member

konstin commented Jun 8, 2022

good question, not sure tbh. i'd like poeple to publish sdists, on the other hand that's where the file-already-exists errors come from

@messense
Copy link
Member Author

messense commented Jun 9, 2022

Yes, publish sdist by default only works well when publish for single OS and architecture only, otherwise file-already-exists errors are inevitable unless --skip-existing is specified.

I'm leaning towards keeping --no-sdist in publish, like we have --no-strip in publish but --strip in build.

This replaces `--no-sdist` with `--sdist` option to only build sdist
when `--sdist` is specified.
@messense messense changed the title Don't build sdist by default Don't build sdist by default in maturin build command Jun 9, 2022
@messense messense merged commit 03a5ee4 into PyO3:main Jun 9, 2022
@messense messense deleted the sdist branch June 9, 2022 13:55
@messense messense removed a link to an issue Oct 10, 2022
6 tasks
dimastbk added a commit to dimastbk/python-calamine that referenced this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants