Merge pull request #3379 from iliya-malecki/main

BigInt speedup

newsfragments/3379.changed.md

@@ -0,0 +1 @@
+Sped up FromPyObject::extract for BigInt and BigUint by up to 43% (although mileage may vary depending on int size and sign)

pyo3-benches/Cargo.toml

@@ -11,6 +11,7 @@ pyo3 = { path = "../", features = ["auto-initialize"] }
 
 [dev-dependencies]
 criterion = "0.5.1"
+num-bigint = "0.4.3"
 
 [[bench]]
 name = "bench_any"
@@ -77,4 +78,9 @@ harness = false
 name = "bench_extract"
 harness = false
 
+[[bench]]
+name = "bench_bigint"
+harness = false
+required-features = ["pyo3/num-bigint"]
+
 [workspace]

pyo3-benches/benches/bench_bigint.rs

@@ -0,0 +1,83 @@
+use criterion::{black_box, criterion_group, criterion_main, Bencher, Criterion};
+
+use pyo3::{types::PyDict, PyAny, Python};
+
+use num_bigint::BigInt;
+
+fn extract_bigint_extract_fail(bench: &mut Bencher<'_>) {
+    Python::with_gil(|py| {
+        let d = PyDict::new(py) as &PyAny;
+
+        bench.iter(|| match black_box(d).extract::<BigInt>() {
+            Ok(v) => panic!("should err {}", v),
+            Err(e) => black_box(e),
+        });
+    });
+}
+
+fn extract_bigint_small(bench: &mut Bencher<'_>) {
+    Python::with_gil(|py| {
+        let int = py.eval("-42", None, None).unwrap();
+
+        bench.iter(|| {
+            let v = black_box(int).extract::<BigInt>().unwrap();
+            black_box(v);
+        });
+    });
+}
+
+fn extract_bigint_big_negative(bench: &mut Bencher<'_>) {
+    Python::with_gil(|py| {
+        let int = py.eval("-10**300", None, None).unwrap();
+
+        bench.iter(|| {
+            let v = black_box(int).extract::<BigInt>().unwrap();
+            black_box(v);
+        });
+    });
+}
+
+fn extract_bigint_big_positive(bench: &mut Bencher<'_>) {
+    Python::with_gil(|py| {
+        let int = py.eval("10**300", None, None).unwrap();
+
+        bench.iter(|| {
+            let v = black_box(int).extract::<BigInt>().unwrap();
+            black_box(v);
+        });
+    });
+}
+
+fn extract_bigint_huge_negative(bench: &mut Bencher<'_>) {
+    Python::with_gil(|py| {
+        let int = py.eval("-10**3000", None, None).unwrap();
+
+        bench.iter(|| {
+            let v = black_box(int).extract::<BigInt>().unwrap();
+            black_box(v);
+        });
+    });
+}
+
+fn extract_bigint_huge_positive(bench: &mut Bencher<'_>) {
+    Python::with_gil(|py| {
+        let int = py.eval("10**3000", None, None).unwrap();
+
+        bench.iter(|| {
+            let v = black_box(int).extract::<BigInt>().unwrap();
+            black_box(v);
+        });
+    });
+}
+
+fn criterion_benchmark(c: &mut Criterion) {
+    c.bench_function("extract_bigint_extract_fail", extract_bigint_extract_fail);
+    c.bench_function("extract_bigint_small", extract_bigint_small);
+    c.bench_function("extract_bigint_big_negative", extract_bigint_big_negative);
+    c.bench_function("extract_bigint_big_positive", extract_bigint_big_positive);
+    c.bench_function("extract_bigint_huge_negative", extract_bigint_huge_negative);
+    c.bench_function("extract_bigint_huge_positive", extract_bigint_huge_positive);
+}
+
+criterion_group!(benches, criterion_benchmark);
+criterion_main!(benches);