Skip to content

Commit

Permalink
Move links key from pyo3 to pyo3-ffi
Browse files Browse the repository at this point in the history
Instead of a fake build dependency, use the links key from pyo3 to pyo3-ffi
which according to [1] is a prerequisite for build scripts to emit meta-data
that can be used by other build scripts which would incidentally ensure the
ordering between the build script of pyo3 and pyo3-ffi that we need.

[1] https://doc.rust-lang.org/cargo/reference/build-script-examples.html#using-another-sys-crate
  • Loading branch information
adamreichold committed Mar 15, 2022
1 parent 0c7a13f commit 415f8c0
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 0 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ categories = ["api-bindings", "development-tools::ffi"]
license = "Apache-2.0"
exclude = ["/.gitignore", ".cargo/config", "/codecov.yml", "/Makefile", "/pyproject.toml", "/noxfile.py"]
edition = "2018"
links = "python"

[dependencies]
cfg-if = "1.0"
Expand Down Expand Up @@ -51,7 +50,6 @@ serde = { version = "1.0", features = ["derive"] }
serde_json = "1.0.61"

[build-dependencies]
pyo3-ffi = { path = "pyo3-ffi", version = "=0.16.1" }
pyo3-build-config = { path = "pyo3-build-config", version = "0.16.1", features = ["resolve-config"] }

[features]
Expand Down
1 change: 1 addition & 0 deletions pyo3-ffi/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ repository = "https://github.com/pyo3/pyo3"
categories = ["api-bindings", "development-tools::ffi"]
license = "Apache-2.0"
edition = "2018"
links = "python"

[dependencies]
libc = "0.2.62"
Expand Down

0 comments on commit 415f8c0

Please sign in to comment.