apply code review comments

PyO3 · Aug 7, 2024 · a0b87d5 · a0b87d5
1 parent b2015e0
commit a0b87d5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/pyo3-ffi/src/compat.rs b/pyo3-ffi/src/compat.rs
@@ -16,11 +16,11 @@ use crate::pyport::Py_ssize_t;
 #[cfg(not(Py_3_13))]
 use std::os::raw::c_int;
 
-#[cfg_attr(docsrs, doc(cfg(all)))]
+#[cfg_attr(docsrs, doc(cfg(all())))]
 #[cfg(Py_3_13)]
 pub use crate::dictobject::PyDict_GetItemRef;
 
-#[cfg_attr(docsrs, doc(cfg(all)))]
+#[cfg_attr(docsrs, doc(cfg(all())))]
 #[cfg(not(Py_3_13))]
 pub unsafe fn PyDict_GetItemRef(
  dp: *mut PyObject,

diff --git a/src/types/list.rs b/src/types/list.rs
@@ -1,6 +1,6 @@
 use std::iter::FusedIterator;
 
-use crate::err::{self, PyErr, PyResult};
+use crate::err::{self, PyResult};
 use crate::ffi::{self, Py_ssize_t};
 use crate::ffi_ptr_ext::FfiPtrExt;
 use crate::internal_tricks::get_ssize_index;
@@ -287,12 +287,10 @@ impl<'py> PyListMethods<'py> for Bound<'py, PyList> {
  /// });
  /// ```
  fn get_item(&self, index: usize) -> PyResult<Bound<'py, PyAny>> {
- let py = self.py();
- let result = unsafe { ffi::compat::PyList_GetItemRef(self.as_ptr(), index as Py_ssize_t) };
- if !result.is_null() {
- return Ok(unsafe { result.assume_owned(py) });
+ unsafe {
+ ffi::compat::PyList_GetItemRef(self.as_ptr(), index as Py_ssize_t)
+ .assume_owned_or_err(self.py())
  }
- Err(PyErr::fetch(py))
  }
 
  /// Gets the list item at the specified index. Undefined behavior on bad index. Use with caution.