Ban pyo3(get, set) on tuple struct field

PyO3 · Mar 18, 2021 · a284b88 · a284b88
1 parent 0c396fa
commit a284b88
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 11 deletions.
diff --git a/pyo3-macros-backend/src/pyclass.rs b/pyo3-macros-backend/src/pyclass.rs
@@ -506,18 +506,21 @@ fn impl_descriptors(
         .flat_map(|(field, fns)| {
             fns.iter()
                 .map(|desc| {
-                    let name = field.ident.as_ref().unwrap().unraw();
-                    let doc = utils::get_doc(&field.attrs, None, true)
-                        .unwrap_or_else(|_| syn::LitStr::new(&name.to_string(), name.span()));
-                    let property_type = PropertyType::Descriptor(&field);
-                    match desc {
-                        FnType::Getter(self_ty) => {
-                            impl_py_getter_def(cls, property_type, self_ty, &name, &doc)
-                        }
-                        FnType::Setter(self_ty) => {
-                            impl_py_setter_def(cls, property_type, self_ty, &name, &doc)
+                    if let Some(name) = field.ident.as_ref().map(|ident| ident.unraw()) {
+                        let doc = utils::get_doc(&field.attrs, None, true)
+                            .unwrap_or_else(|_| syn::LitStr::new(&name.to_string(), name.span()));
+                        let property_type = PropertyType::Descriptor(&field);
+                        match desc {
+                            FnType::Getter(self_ty) => {
+                                impl_py_getter_def(cls, property_type, self_ty, &name, &doc)
+                            }
+                            FnType::Setter(self_ty) => {
+                                impl_py_setter_def(cls, property_type, self_ty, &name, &doc)
+                            }
+                            _ => unreachable!(),
                         }
-                        _ => unreachable!(),
+                    } else {
+                        bail_spanned!(field.span() => "get/set are not supported on tuple struct field");
                     }
                 })
                 .collect::<Vec<syn::Result<TokenStream>>>()

diff --git a/tests/ui/invalid_property_args.rs b/tests/ui/invalid_property_args.rs
@@ -24,4 +24,7 @@ impl ClassWithSetter {
     fn setter_with_too_many_args(&mut self, py: Python, foo: u32, bar: u32) {}
 }
 
+#[pyclass]
+struct TupleGetterSetter(#[pyo3(get, set)] i32);
+
 fn main() {}
diff --git a/tests/ui/invalid_property_args.stderr b/tests/ui/invalid_property_args.stderr
@@ -15,3 +15,9 @@ error: setter function can have at most two arguments ([pyo3::Python,] and value
    |
 24 |     fn setter_with_too_many_args(&mut self, py: Python, foo: u32, bar: u32) {}
    |                                                                        ^^^
+
+error: get/set are not supported on tuple struct field
+  --> $DIR/invalid_property_args.rs:28:44
+   |
+28 | struct TupleGetterSetter(#[pyo3(get, set)] i32);
+   |                                            ^^^