Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support __getattribute__ in #[pymethods] #2186

Closed
davidhewitt opened this issue Feb 24, 2022 · 0 comments · Fixed by #2187
Closed

Support __getattribute__ in #[pymethods] #2186

davidhewitt opened this issue Feb 24, 2022 · 0 comments · Fixed by #2187
Labels
enhancement

Comments

@davidhewitt
Copy link
Member

Yes, [__getattr__ and __getattribute__] share the one slot, however we have this code which makes the slot behave like __getattr__. I think in principle we could support both methods like CPython.

Originally posted by @davidhewitt in #2173 (comment)
birkenfeld added a commit that referenced this issue Feb 25, 2022
@birkenfeld
Protocols: implement __getattribute__
d8153cf 
converting tp_getattro to a shared slot

Fixes #2186
@birkenfeld birkenfeld mentioned this issue Feb 25, 2022
Merged
birkenfeld added a commit that referenced this issue Feb 26, 2022
@birkenfeld
Protocols: implement __getattribute__
0678f11 
converting tp_getattro to a shared slot

Fixes #2186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Protocols: implement __getattribute__ PyO3/pyo3
1 participant
@davidhewitt