Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip the build host Python interpreter detection when building portable "abi3" extensions #2292

Closed
ravenexp opened this issue Apr 11, 2022 · 0 comments · Fixed by #2293
Closed

Skip the build host Python interpreter detection when building portable "abi3" extensions #2292

ravenexp opened this issue Apr 11, 2022 · 0 comments · Fixed by #2293
Labels
enhancement

Comments

@ravenexp
Copy link
Contributor

Continuation of the discussion in PyO3/maturin#875

I also think PyO3 should also be doing what maturin has been doing for a long time:
make PYO3_NO_PYTHON=1 behavior the default when compiling "abi3" extensions.

This change will help to eliminate the last remaining use of PYO3_NO_PYTHON by maturin
and make cargo build and maturin build behave more or less the same.

I'll add a draft PR below.
ravenexp added a commit to ravenexp/pyo3 that referenced this issue Apr 11, 2022
@ravenexp
pyo3-build-config: Build "abi3" extensions without an interpreter
809a3ec 
Ignore the build host Python interpreter configuration when
compiling portable "abi3" extension modules.
Such extensions should not depend on a concrete Python version
or build configuration by design.

Maturin already does this when building "abi3" extension wheels
by defining `PYO3_NO_PYTHON=1` for Cargo when an `abi3-py3*`
feature is detected.

Closes PyO3#2292
@ravenexp ravenexp mentioned this issue Apr 11, 2022
Merged
ravenexp added a commit to ravenexp/pyo3 that referenced this issue Apr 12, 2022
@ravenexp
pyo3-build-config: Build "abi3" extensions without an interpreter
401b0c7 
Support compiling portable "abi3" extension modules even when
the build host Python interpreter configuration is not available
or the discovered Python interpreter version is not supported.

Maturin already implements this by building "abi3" extension wheels
with `PYO3_NO_PYTHON` environment veriable set for cargo when
an `abi3-py3*` feature is detected.

Closes PyO3#2292
ravenexp added a commit to ravenexp/pyo3 that referenced this issue Apr 13, 2022
@ravenexp
pyo3-build-config: Build "abi3" extensions without an interpreter
ae7e1f5 
Support compiling portable "abi3" extension modules even when
the build host Python interpreter configuration is not available
or the discovered Python interpreter version is not supported.

Maturin already implements this by building "abi3" extension wheels
with `PYO3_NO_PYTHON` environment veriable set for cargo when
an `abi3-py3*` feature is detected.

Closes PyO3#2292
mejrs pushed a commit to mejrs/pyo3 that referenced this issue Apr 20, 2022
@ravenexp @mejrs
pyo3-build-config: Build "abi3" extensions without an interpreter
9db5f8a 
Support compiling portable "abi3" extension modules even when
the build host Python interpreter configuration is not available
or the discovered Python interpreter version is not supported.

Maturin already implements this by building "abi3" extension wheels
with `PYO3_NO_PYTHON` environment veriable set for cargo when
an `abi3-py3*` feature is detected.

Closes PyO3#2292
mejrs pushed a commit to mejrs/pyo3 that referenced this issue May 1, 2022
@ravenexp @mejrs
pyo3-build-config: Build "abi3" extensions without an interpreter
c0cfd54 
Support compiling portable "abi3" extension modules even when
the build host Python interpreter configuration is not available
or the discovered Python interpreter version is not supported.

Maturin already implements this by building "abi3" extension wheels
with `PYO3_NO_PYTHON` environment veriable set for cargo when
an `abi3-py3*` feature is detected.

Closes PyO3#2292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pyo3-build-config: Build "abi3" extensions without an interpreter ravenexp/pyo3
1 participant
@ravenexp