PySet::pop sets the global exception state #688
Labels
Comments
Alexander-N
added a commit
to Alexander-N/pyo3
that referenced
this issue
Jan 10, 2020
Leaving Python's global exception state is misleading, e.g. subsequent calls of `py.eval` will fail. Closes PyO3#688
Alexander-N
added a commit
to Alexander-N/pyo3
that referenced
this issue
Jan 10, 2020
Leaving Python's global exception state is misleading, e.g. subsequent calls of `py.eval` will fail. Closes PyO3#688
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Discovered by running the test suite locally.
The
PySet_Popthat’s run as part of thetest_set_popwill return NULL and set the global exception state (raise an exception) when the set is empty. We handle theNULLcase and return anOption<T>, but the exception state remains set.Given that the convention in PyO3 is to convert exceptions to return values, this can be very misleading. In particular, this causes the test suite to fail further along when one of the tests invokes
py.evaland then converts this exception to aResult.To reproduce try:
cargo test --lib -- --test-threads=1.The text was updated successfully, but these errors were encountered: