Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functions which cast reference to pointer are not unsafe. #1047

Merged
merged 1 commit into from
Jul 18, 2020
Merged

Functions which cast reference to pointer are not unsafe. #1047

merged 1 commit into from
Jul 18, 2020

Conversation

davidhewitt
Copy link
Member

... it's the later usage of that pointer that's unsafe! 😄

@davidhewitt
Copy link
Member Author

cc @kngwyu - I just want to check you agree with me on this one? Best to have a reviewer other than me as it's changing "unsafe" code...

kngwyu
kngwyu approved these changes Jul 18, 2020
View reviewed changes
Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable for me.

@kngwyu
Copy link
Member

kngwyu commented Jul 18, 2020

Thanks!

@kngwyu kngwyu merged commit 8bbdbc4 into PyO3:master Jul 18, 2020
@davidhewitt davidhewitt deleted the cast-to-ptr-is-safe branch August 10, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kngwyu kngwyu kngwyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhewitt @kngwyu