Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant iter test #1091

Merged
merged 1 commit into from
Aug 8, 2020
Merged

Conversation

davidhewitt
Copy link
Member

This test produces extra "Exception state should not be set." output, which I found confusing.

$ cargo test --test test_various incorrect
    Finished test [unoptimized + debuginfo] target(s) in 0.02s
     Running target/debug/deps/test_various-756839897d6f2700

running 1 test
Exception state should not be set.
test incorrect_iter ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 7 filtered out

It's also redundant as the following test checks exactly the same behaviour:

pyo3/src/types/iterator.rs

Lines 183 to 184 in 3809e2b

#[test]
fn int_not_iterable() {

Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@kngwyu kngwyu merged commit c66bc54 into PyO3:master Aug 8, 2020
@davidhewitt davidhewitt deleted the remove-redundant-test branch December 24, 2021 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants