pyerr: improve debug & display impls #1275
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the ergonomics of
PyErr
's debug output.Now, instead of
PyErr { type: 0x... }
the repr of type and value are printed (usingPython::with_gil
to acquire the GIL if needed). We already acquire the GIL in theDisplay
impl so I think we have acceptable precedent to do this. It also makes the output much more useful for PyO3 users.As a simplification, I also removed the special
impl Debug
andimpl Display
forPyException
. They now just use the underlying Python object's.repr()
and.str()
, just likePyAny
. I think there's a strong consistency argument for doing this.Before:
After: