Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let pyconfig.h not define Py_ENABLE_SHARED #1359

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Let pyconfig.h not define Py_ENABLE_SHARED #1359

merged 1 commit into from
Jan 5, 2021

Conversation

dalcde
Copy link
Contributor

@dalcde dalcde commented Jan 4, 2021

If there is no line that defines Py_ENABLE_SHARED in pyconfig.h, then it is false

This fixes an issue described in #1221

If there is no line that defines Py_ENABLE_SHARED in `pyconfig.h`, then it is false
@davidhewitt
Copy link
Member

davidhewitt commented Jan 4, 2021

Hi @dalcde thanks very much for the PR.

I'm slightly reluctant to merge this, because the header parsing is slightly broken for a few various reasons and I'm thinking about removing it anyway in PyO3 0.14. See #1337

Can you tell me a bit more about your use case? Perhaps we can come up with a better way to configure PyO3 in your situation.

@dalcde
Copy link
Contributor Author

dalcde commented Jan 4, 2021 via email

Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kngwyu
Copy link
Member

kngwyu commented Jan 5, 2021

I'm slightly reluctant to merge this, because the header parsing is slightly broken for a few various reasons and I'm thinking about removing it anyway in PyO3 0.14.

I don't think it's very straightforward to remove the header parsing and it'll take time. So I don't think merging this now is harmful.

@davidhewitt
Copy link
Member

Ok 👍

@davidhewitt davidhewitt merged commit b152fd6 into PyO3:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants