rust 1.50: clippy and lint fixes #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
commented
Feb 11, 2021
| @@ -10,15 +10,15 @@ use std::os::raw::c_int; | |||
| #[derive(Debug)] | |||
| pub enum PyMethodDefType { | |||
| /// Represents class `__new__` method | |||
| New(PyMethodDef), | |||
| New(PyMethodDef<ffi::newfunc>), | |||
There was a problem hiding this comment.
The changes in this module are technically breaking, but it's #[doc(hidden)] internals so I think this refactor is fine.
I did it because it removes some of the type assertions from runtime to compile time, which can only be a good thing for performance 🚀
There was a problem hiding this comment.
I decided this was fine to merge before the patch release based on comment by dtolnay here: https://www.reddit.com/r/rust/comments/ey0ul0/handling_breaking_api_changes/fgew8d2
davidhewitt
force-pushed
the
fixes-rust-1_50
branch
2 times, most recently
from
8a55c4c
to
1aaa856
Compare
davidhewitt
force-pushed
the
fixes-rust-1_50
branch
from
1aaa856
to
b2675b1
Compare
This was referenced Feb 11, 2021
Merged
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.