Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore syn::Type::Group in is_python #1505

Merged
merged 2 commits into from
Mar 20, 2021
Merged

Ignore syn::Type::Group in is_python #1505

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adc6e6f
Ignore `syn::Type::Group` in `is_python`
scalexm Mar 18, 2021
e34e87a
1505: add CHANGELOG and test
davidhewitt Mar 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pyo3-macros-backend/src/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,11 @@ macro_rules! ensure_spanned {
}

/// Check if the given type `ty` is `pyo3::Python`.
pub fn is_python(ty: &syn::Type) -> bool {
pub fn is_python(mut ty: &syn::Type) -> bool {
while let syn::Type::Group(group) = ty {
// Macros can create invisible delimiters around types.
ty = &*group.elem;
}
match ty {
syn::Type::Path(typath) => typath
.path
Expand Down