pyclass: support extending Exception types #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birkenfeld
reviewed
May 3, 2021
davidhewitt
force-pushed
the
inherit-exceptions
branch
from
b440e69
to
c27adcf
Compare
|
Does this feature make |
davidhewitt
force-pushed
the
inherit-exceptions
branch
from
c27adcf
to
d81abe8
Compare
|
In the long run, yes. But that'll come when we have a full |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements support for
#[pyclass(extends=Exception)].I expected there to be bigger issues around doing this; it turned out to be very easy.
cc @Stranger6667 who was asking about this on Gitter just the other day.