Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for extracting PathBuf from pathlib.Path #1654

Merged
merged 1 commit into from
Jun 5, 2021
Merged

Add support for extracting PathBuf from pathlib.Path #1654

merged 1 commit into from
Jun 5, 2021

Conversation

messense
Copy link
Member

@messense messense commented Jun 5, 2021

No description provided.

@messense messense force-pushed the pathlib branch 2 times, most recently from be3735b to 0b67577 Compare June 5, 2021 06:22
@messense
Copy link
Member Author

messense commented Jun 5, 2021

datafusion probably wants this: apache/datafusion#491

birkenfeld
birkenfeld reviewed Jun 5, 2021
View reviewed changes
src/conversions/osstr.rs Outdated Show resolved Hide resolved
davidhewitt
davidhewitt reviewed Jun 5, 2021
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good idea, I was wondering about doing similar in the past. Couple of thoughts...

Also definitely worthy of a CHANGELOG entry! 🚀

src/conversions/osstr.rs Outdated Show resolved Hide resolved
src/conversions/osstr.rs Outdated Show resolved Hide resolved
@messense messense marked this pull request as ready for review June 5, 2021 06:58
davidhewitt
davidhewitt approved these changes Jun 5, 2021
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@messense messense merged commit f49f444 into PyO3:main Jun 5, 2021
@messense messense deleted the pathlib branch June 5, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birkenfeld birkenfeld birkenfeld left review comments

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@messense @birkenfeld @davidhewitt