Added size_hint impls for {PyDict,PyList,PySet,PyTuple}Iterators
#1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this needs to take into account the current position of the iterator, since size_hint is supposed to return the remaining length, not the total length. |
|
As well as the above, it would be awesome to add tests for these |
ohadravid
force-pushed
the
size_hints
branch
2 times, most recently
from
d3c4036
to
c613282
Compare
|
@birkenfeld 🤦♂️ right! fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I've added
size_hintimpls for the iterators which can support it (while defaulting to 0 on Python-related errors).Should make
some_py_dict.iter().map(...).collect()faster by avoiding allocations!