Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyPy: the PyList/Tuple_GET/SET macros are defined as functions #1713

Merged
merged 1 commit into from
Jul 4, 2021
Merged

PyPy: the PyList/Tuple_GET/SET macros are defined as functions #1713

merged 1 commit into from
Jul 4, 2021

Conversation

birkenfeld
Copy link
Member

No description provided.

davidhewitt
davidhewitt approved these changes Jul 4, 2021
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks! We should definitely add a CHANGELOG note, maybe something like

- Fix crashes on PyPy due to incorrect definitions of `PyList_SET_ITEM`

@birkenfeld birkenfeld mentioned this pull request Jul 4, 2021
Merged
@davidhewitt
Copy link
Member

Awesome, thanks!

@davidhewitt davidhewitt merged commit 4ed0383 into main Jul 4, 2021
@davidhewitt davidhewitt deleted the pypy_macros branch July 4, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@birkenfeld @davidhewitt