Add 128bit integer support #173
Conversation
src/ffi2/longobject.rs
Outdated
| pub fn _PyLong_FromByteArray( | ||
| arg1: *const c_uchar, | ||
| arg2: size_t, | ||
| arg3: c_int, // is_little_endian |
There was a problem hiding this comment.
The arguments should better be given their original names, such as is_little_endian, instead of arg3.
src/objects/num2.rs
Outdated
| } | ||
| } | ||
| impl<'source> FromPyObject<'source> for $rust_type { | ||
| #[cfg(target_endian = "little")] |
There was a problem hiding this comment.
Having the cfg attached to the method will make the compilation fail if when target_endian is big. If I understood the _PyLong_AsByteArray documentation correctly, extract should also work on big endian.
There was a problem hiding this comment.
Ah it's just my mistake, thanks.
src/objects/num3.rs
Outdated
| @@ -138,6 +138,55 @@ macro_rules! int_convert_u64_or_i64 ( | |||
| ) | |||
| ); | |||
|
|
|||
| // for 128bit Integers | |||
| macro_rules! int_convert_bignum ( | |||
There was a problem hiding this comment.
That macro and its tests should go in a common file for python 2 and 3. I know there's already some duplication between num2 and num3, but we shouldn't make it worse.
There was a problem hiding this comment.
I know there's already some duplication between num2 and num3, but we shouldn't make it worse.
👍
src/objects/num3.rs
Outdated
|
|
||
| #[test] | ||
| #[cfg(not(Py_LIMITED_API))] | ||
| fn test_i128_min() { |
|
Thank you for your pull request! The implementation looks good; I've added comments on some things that should be changed before merging. |
|
Thanks for review, and now ready to be reviewed again |
|
Look great now, thank you! |
From 1.26, u128 and i128 are stable so let's support them(see rust-lang/rust#35118).
This PR allows conversion between rust 128bit integers and Python's long(in python3, int class), via
_PyLong_FromByteArrayand_PyLong_AsByteArray.I referenced
https://github.com/python/cpython/blob/master/Include/longobject.h (for python 3)
and
https://github.com/python/cpython/blob/2.7/Include/longobject.h (for python2)
for this PR.