Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyo3-build-config: make InterpreterConfig public #1848

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

indygreg
Copy link
Contributor

PyOxidizer will want to create interpreter config files. Rather
than reinvent the logic for reading/writing these files, I think
it makes sense to consume the pyo3-build-config crate so we can
use the InterpreterConfig type directly. But the symbol needs
to be public to allow us to do that.

(Strictly speaking I could probably hack my way into getting an
instance of InterpreterConfig via get() and use that. But that
is exceptionally hacky.)

@davidhewitt
Copy link
Member

👍 I think this needs to happen.

Shall we go a little further and remove the #[doc(hidden)]?

I think to make this useful in practice you may also want PythonVersion, PythonImplementation , BuildFlags and BuildFlag made public too?

PyOxidizer will want to create interpreter config files. Rather
than reinvent the logic for reading/writing these files, I think
it makes sense to consume the `pyo3-build-config` crate so we can
use the `InterpreterConfig` type directly. But the symbol needs
to be public to allow us to do that. And in order to allow direct
construction, we need to make all the types referenced by its fields
public as well.
@indygreg
Copy link
Contributor Author

Yeah, we need to make all referenced fields public as well. I would have realized that if I actually tried to use this branch :) Good catch.

I rebased and force pushed a change to expose the additional types.

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@davidhewitt davidhewitt merged commit 5e8d43c into PyO3:main Aug 31, 2021
@davidhewitt davidhewitt mentioned this pull request Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants