Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pep 604: use T | U instead of Union[T, U] in messaging #1885

Merged
merged 1 commit into from
Sep 25, 2021
Merged

pep 604: use T | U instead of Union[T, U] in messaging #1885

merged 1 commit into from
Sep 25, 2021

Conversation

davidhewitt
Copy link
Member

See #1781

I think T | U is nicer syntax than Union[T, U]. Also, we only use it in error messages, so I think we can use this syntax on all Python versions (not just 3.10+).

birkenfeld
birkenfeld approved these changes Sep 25, 2021
View reviewed changes
Copy link
Member

@birkenfeld birkenfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.

@davidhewitt davidhewitt merged commit d736256 into PyO3:main Sep 25, 2021
@davidhewitt davidhewitt deleted the pep-604 branch September 25, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birkenfeld birkenfeld birkenfeld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhewitt @birkenfeld