Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: formal support for Python 3.10 #1889

Merged
merged 3 commits into from
Sep 29, 2021
Merged

Conversation

davidhewitt
Copy link
Member

This PR goes through the FFI changes listed in #1781, and also adds an abi3-py310 feature.

Given that we have also tested Python 3.10 on CI for a long time, and this PR adds the documented C API changes, I think we can call Python 3.10 officially supported now.

I also made a tidy-up pass to use _Py_NewRef in expressions in a bunch of places, because imo it's nicer than calling Py_INCREF in a separate satement. And we can define _Py_NewRef on all supported Python versions (not just 3.10).

Closes #1781

(The PEP 622 support is tracked separately in #1714 - I don't think we'll have this ready by the time 3.10 is released.)

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@mejrs mejrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!..just two nits

src/ffi/modsupport.rs Outdated Show resolved Hide resolved
src/ffi/object.rs Show resolved Hide resolved
davidhewitt and others added 2 commits September 29, 2021 08:02
Co-authored-by: Bruno Kolenbrander <59372212+mejrs@users.noreply.github.com>
@davidhewitt davidhewitt merged commit c986b5d into PyO3:main Sep 29, 2021
@davidhewitt davidhewitt deleted the py310 branch September 29, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preparation for Python 3.10 release
2 participants