Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fallback for __mod__ magic method #1934

Merged
merged 3 commits into from
Oct 19, 2021
Merged

Add fallback for __mod__ magic method #1934

merged 3 commits into from
Oct 19, 2021

Conversation

lycantropos
Copy link
Contributor

@lycantropos lycantropos commented Oct 19, 2021 •
edited
Loading

  • an entry in CHANGELOG.md
  • docs to all new functions and / or detail in the guide
  • tests for all new or changed functions

Resolves #1933.

davidhewitt
davidhewitt approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@davidhewitt davidhewitt merged commit 7349513 into PyO3:main Oct 19, 2021
@lycantropos lycantropos deleted the rmod-fallback branch October 25, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No fallback to __rmod__ magic method when __mod__ is not implemented
2 participants
@lycantropos @davidhewitt