Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffi: restore _PyImport_FindExtensionObject on Python 3.10 #1942

Merged
merged 1 commit into from
Oct 24, 2021

Conversation

indygreg
Copy link
Contributor

This symbol was initially removed from 3.10. But it was restored
late in the 3.10 development cycle in time for 3.10.0. See
https://bugs.python.org/issue45307.

@indygreg
Copy link
Contributor Author

I rely on this symbol in PyOxidizer on Windows. So the missing symbol is potentially blocking PyOxidizer from supporting Python 3.10 on Windows. I might be able to work around by defining the symbol reference in my crate. But I can't recall if Cargo allows you to do this without putting up a fight. So having this in a pyo3 release ASAP would be preferred. I'm tentatively planning to release PyOxidizer this weekend. But life may intervene even if I'm blocked on pyo3: so no pressure!

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Happy to get this into a release soon - as per #1921 I just need to write some documentation (which I'm halfway through and may finish tomorrow). So we may not release tomorrow, but perhaps within a week.

See coments below for a couple of tweaks please...

src/ffi/cpython/import.rs Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@indygreg indygreg force-pushed the restore-findextensionobject branch from 1cefc7b to 7377b2a Compare October 23, 2021 22:23
This symbol was initially removed from 3.10. But it was restored
late in the 3.10 development cycle in time for 3.10.0. See
https://bugs.python.org/issue45307. It is slated for removal in
3.11.
@indygreg indygreg force-pushed the restore-findextensionobject branch from 7377b2a to a5f804e Compare October 23, 2021 22:25
@indygreg
Copy link
Contributor Author

I force pushed with a rebase + incorporation of the suggested changes.

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks! Will try to get that release cooking ASAP!

@davidhewitt davidhewitt merged commit ae186ef into PyO3:main Oct 24, 2021
@indygreg indygreg deleted the restore-findextensionobject branch October 24, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants