Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1959 - Add Python Typing Hints to the Guide #1968

Merged
merged 3 commits into from
Nov 11, 2021
Merged

#1959 - Add Python Typing Hints to the Guide #1968

merged 3 commits into from
Nov 11, 2021

Conversation

KRunchPL
Copy link
Contributor

@KRunchPL KRunchPL commented Nov 6, 2021

PR adds another Appendix to the Guide describing how to use pyi files to provide types hinting in Python packages built using PyO3+Maturin as suggested in #1959

@KRunchPL KRunchPL marked this pull request as ready for review November 6, 2021 14:38
@messense
Copy link
Member

messense commented Nov 6, 2021

@KRunchPL
Copy link
Contributor Author

KRunchPL commented Nov 6, 2021

Thanks for pointing it out, I somehow missed that information before.

I have added the section about simpler solution to the document and also fixes the formatting pointed out by CI/CD.

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is a useful resource for future readers!

@davidhewitt davidhewitt linked an issue Nov 11, 2021 that may be closed by this pull request
@davidhewitt davidhewitt merged commit a978b08 into PyO3:main Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put information about stub files in the documentation
3 participants