opt: move fastcall boilerplate out of generated code #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
opt-argument-extraction
branch
6 times, most recently
from
829edc4 to
8116002
Compare
davidhewitt
force-pushed
the
opt-argument-extraction
branch
from
8116002 to
1a782ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves code for fastcall from proc macro output (converting arguments from raw pointers to slices etc) into
pyo3::impl_::extract_argument.This is a huge further reduction (~15%) of the LLVM line count of
pyo3-pytests.No noticeable change to benchmarks, so again this should be a nice compile speedup.