-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix soundness issues w/r ExactSizeIterator
#2124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely work, thank you! Excellent set of tests. I think worthy of a CHANGELOG?
I only commented on the list implementation, however all comments apply equally to the tuple case too.
Looks great! I just want to take a moment to play with this locally to confirm if the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep works great!
@davidhewitt did it make a difference? I'm curious now :) |
No measurable perf difference. Code size - a little bit, figured as I couldn't see a perf change overall it seemed right 👍 |
Fixes #2118