refactor: simpler pyclass internals #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
simpler-default-items
branch
from
baf39ef to
0c57696
Compare
davidhewitt
commented
Feb 9, 2022
Comment on lines
+196
to
199
| impl #cls { | ||
| #[doc(hidden)] | ||
| #wrapper | ||
| } |
There was a problem hiding this comment.
Realising that the wrapper could be an associated method of the struct is interesting for a couple of reasons:
- We have some rather ugly code to recursively
replace_self(in method argument types and return values) - if all Pymethod wrappers were placed on the struct like this, we won't need it. - In addition, because the struct is a shared namespace, we could use this safeguard against multiple Python definitions with the same name. (That's exactly why I did it here; so that
#[new]can only be implemented once.)
I'll probably play around with this in a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just makes a few cleanups to the
#[pyclass]internals which I noticed were possible the other day:pyclass_default_itemstrait into the inlined items created in refactor: inline pyclass_intrinsic_items #2153Overall seems like a nice simplification; makes the machinery of the pyclass internals a bit more uniform. Also reduces
llvm-linescount ofpytestscrate by around 1%. So nothing major, still seems nice.