pypy: support 7.3.8 #2217
Merged
pypy: support 7.3.8 #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mattip |
mattip
reviewed
Mar 8, 2022
src/impl_/pymodule.rs
Outdated
| @@ -71,6 +71,21 @@ impl ModuleDef { | |||
| panic_result_into_callback_output( | |||
| py, | |||
| std::panic::catch_unwind(move || -> PyResult<_> { | |||
| #[cfg(all(PyPy, not(Py_3_8)))] | |||
| { | |||
| const PYPY_GOOD_VERSION: [u8; 3] = [7, 3, 9]; | |||
There was a problem hiding this comment.
Maybe I don't understand?
Suggested change
| const PYPY_GOOD_VERSION: [u8; 3] = [7, 3, 9]; | |
| const PYPY_GOOD_VERSION: [u8; 3] = [7, 3, 8]; |
There was a problem hiding this comment.
Haha good catch, I set it higher when manually testing 😅
Shouldn't v7.3.8 be clean, and the warning only emitted for v7.3.7 and under? |
davidhewitt
force-pushed
the
pypy-7.3.8
branch
2 times, most recently
from
88ad9f4 to
5f61d8e
Compare
Yes, I was running 7.3.8 locally so fiddled with versions to verify the warning. Force-pushed a corrected implementation which should now only warn on 7.3.7 and older ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://foss.heptapod.net/pypy/pypy/-/issues/3688#note_181074 the official PyPy line will be that PyPy 3.7 versions older than 7.3.8 should be treated as bugged.
Hence here I'm updating definitions to support 7.3.8 and add a warning if a user tries to import a PyO3 module with an older PyPy version.