Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on CI with cargo-nextest #2236

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

messense
Copy link
Member

https://github.com/nextest-rs/nextest

Try it out to see if it can help speeding up CI runs.

@messense
Copy link
Member Author

messense commented Mar 20, 2022

test marker::tests::test_acquire_gil ... FAILED

pyo3/src/marker.rs

Lines 993 to 1010 in b8dd626

fn test_acquire_gil() {
const GIL_NOT_HELD: c_int = 0;
const GIL_HELD: c_int = 1;
let state = unsafe { crate::ffi::PyGILState_Check() };
assert_eq!(state, GIL_NOT_HELD);
{
let gil = Python::acquire_gil();
let _py = gil.python();
let state = unsafe { crate::ffi::PyGILState_Check() };
assert_eq!(state, GIL_HELD);
drop(gil);
}
let state = unsafe { crate::ffi::PyGILState_Check() };
assert_eq!(state, GIL_NOT_HELD);
}

This one seems problematic with cargo-nextest.

https://nexte.st/book/how-it-works.html

@messense messense marked this pull request as ready for review March 20, 2022 07:06
@birkenfeld
Copy link
Member

Last time I checked, nextest did not support and run doctests. So you'd have to add "cargo test --doc" as a separate step?

@messense
Copy link
Member Author

Last time I checked, nextest did not support and run doctests. So you'd have to add "cargo test --doc" as a separate step?

In that case I think we should wait for nextest-rs/nextest#16, otherwise the added cargo test --doc steps might just slow things down and make the CI setup more complex.

@messense messense marked this pull request as draft March 20, 2022 07:22
@messense messense added CI Continuous Integration CI-skip-changelog Skip checking changelog entry labels Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants